Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Jenkins version #1682

Merged
merged 1 commit into from
Aug 10, 2023
Merged

Update default Jenkins version #1682

merged 1 commit into from
Aug 10, 2023

Conversation

Jonny-vb
Copy link
Contributor

Update default Jenkins version for Docker iamges.

Important for Windows images as only a single tag is built for it based off the default version and the existing used tag now has a Stored XSS vulnerability

Submitter checklist

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this change is not harmful, I believe it is not required.

The build process in production environments always passes a JENKINS_VERSION and a JENKINS_SHA for the container image being built. We don't rebuild old container images, but rely on the regular pace of Jenkins releases to deliver new containers with new Jenkins versions.

@timja timja merged commit 6d5e785 into jenkinsci:master Aug 10, 2023
13 checks passed
@Jonny-vb
Copy link
Contributor Author

While this change is not harmful, I believe it is not required.

The build process in production environments always passes a JENKINS_VERSION and a JENKINS_SHA for the container image being built. We don't rebuild old container images, but rely on the regular pace of Jenkins releases to deliver new containers with new Jenkins versions.

This is true for linux based images, but not the windows based unfortunately - I should have linked my old issue covering this: #1490

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants