Implement the DSL for commentFilePath to fix #514

[hibes]

No description provided.

[hibes]

@samrocketman, had some issues with the other PR (#637). This one has the collection of changes and is up to date with master.

[samrocketman]

code-wise looks ok to me. I'm not sure how to test this.

[Kentalot]

Maybe make a seed job and have it try to process a dsl with this option on?

[samrocketman]

I don't have time to work on testing this at the moment since I'm preparing for Jenkins World next week where I'm presenting.

[Kentalot]

Oh, looking at your test infrastructure, it doesn't use groovy, which dsl requires, so unless testing can support groovy, that wouldn't be a good way to test. Looks like none of the other DSL gets tested. Just looking at the code of this merge, it looks reasonable.

[Kentalot]

Actually, isn't this changed now according to this: #637 (comment)

@bjoernhaeuser ?

[samrocketman]

Yeah, the job dsl testing happens manually at this time.

[hibes]

@samrocketman

Merging is blocked
Merging can be performed automatically with 1 approving review.

I pushed the README update requested by @Kentalot.

[samrocketman]

I'm not working on this (or any open source projects) until after Jenkins World next week.

[Kentalot]

@samrocketman Any updates on this one? 👍

[samrocketman]

Not available for coding. Traveling on vacation at the moment.

[samrocketman]

I will be back home Oct 17th. If you see no action in the week following that date feel free to ping me again to remind me.

[bjoernhaeuser]

I vote for merging.

[samrocketman]

@bjoernhaeuser feel free to merge LGTM

[bjoernhaeuser]

@samrocketman thanks for approving.

[Kentalot]

Awesome now that this is merged, any way we could get #682 merged? :)

[Kentalot]

@bjoernhaeuser I tested this on my DSL job and it seems to not work as it somehow does not seem to find commentFilePath method that takes in a closure. Not sure what's happening. Your #664 update also fails with a similar error. I checked to make sure i have the latest ghprb plugin version (1.42.0). commitStatus and buildStatus extensions work just fine. I don't see anything wrong with your code and the only difference I could see between the working ones (commitStatus and buildStatus) and the non-working ones (commentFilePath and cancelBuildsOnUpdate) is the latter ones have their methods public. I doubt that's the issue, but I couldn't see any other difference.

Here's the error:

Processing DSL script PipelineJob.groovy
ERROR: (PullRequestTrigger.groovy, line 110) No signature of method: javaposse.jobdsl.dsl.helpers.triggers.TriggerContext.cancelBuildsOnUpdate() is applicable for argument types: (jobs.utils.builders.pipelines.scripts.PullRequestTrigger$_addTriggerTo_closure1$_closure2$_closure3$_closure6) values: [jobs.utils.builders.pipelines.scripts.PullRequestTrigger$_addTriggerTo_closure1$_closure2$_closure3$_closure6@6052ddc2]

and the code snippet:

extensions {
                    commitStatus {
                        context(gitStatus.toString())
                        triggeredStatus('Triggering Jenkins...')
                        startedStatus("Running $gitStatus on Jenkins...")
                        addTestResults(true)
                        completedStatus('SUCCESS', 'Tests passed')
                        completedStatus('FAILURE', 'Tests failed')
                        completedStatus('PENDING', 'Testing in progress...')
                        completedStatus('ERROR', 'Pipeline crashed')
                    }
                    buildStatus {
                        completedStatus('SUCCESS', successMessage)
                        completedStatus('FAILURE', failureMessage)
                        completedStatus('ERROR',
                                'There was an error in the infrastructure, please contact the Jenkins maintainer.')
                    }
                    cancelBuildsOnUpdate {
                        overrideGlobal(true)
                    }
                    commentFilePath {
                            commentFilePath(extraCommentFilePath)
                    }                    
                }