Use Java 17 features in source code

[MarkEWaite]

Use Java 17 features in source code

Open Rewrite migrate to Java 17 provided the transformations and they all pass automated tests.

Several nice readability improvements are provided by Java 17.

Testing done

Automated tests pass.

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[rsandell]

Nice!
Though I am personally allergic to plugins that require newer Java versions than the Jenkins Core version they depend on, maybe you changed that dependency/pom in another PR?.

[MarkEWaite]

Nice! Though I am personally allergic to plugins that require newer Java versions than the Jenkins Core version they depend on, maybe you changed that dependency/pom in another PR?.

I agree with you that requiring newer Java versions in this plugin is very fast. This is a very special case for its transition to Java 17 because JGit 7.0.0, requires Java 17. Other plugins (like the git plugin) do not need that fast paced transition to Java 17. More details about the transition of this plugin to Java 17 are available in:

• Use JGit 7.0.0, require Java 17 and Jenkins 2.463 or newer #1170

The plugin does not require a newer Java version than the Jenkins version core on which it depends. It requires Jenkins 2.463 or newer which is the first Jenkins weekly version that requires Java 17. Users of the Jenkins LTS won't see this upgrade until the 30 Oct 2024 Jenkins LTS release that requires Java 17 or newer.

[MarkEWaite]

I think that this plugin should make its next transition to Jakarta EE 9 and Spring Security 6.x soon after we release the 30 Oct 2024 LTS because I don't think it is healthy in the long term to have this plugin use a weekly release as its minimum Jenkins version baseline.

The draft pull request that proposes that change is:

• Test JGit 7.0.0 with Jakarta EE 9 Jenkins core #1172

Does that make sense to others or am I missing something there?