Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use non-deprecated JGit methods to get references #1191

Merged

Conversation

MarkEWaite
Copy link
Contributor

Use non-deprecated JGit methods to get references

The JGit 7.0.0 upgrade reminded me that it is unwise to depend on deprecated methods from JGit because they will eventually be removed. Better to stop using the deprecated methods now and avoid problems in the future.

Testing done

Confirmed that automated tests pass.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

The JGit 7.0.0 upgrade reminded me that it is unwise to depend on
deprecated methods from JGit because they will eventually be removed.
Better to stop using the deprecated methods now and avoid problems in
the future.
@MarkEWaite MarkEWaite requested a review from a team as a code owner September 17, 2024 02:07
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label Sep 17, 2024
@MarkEWaite MarkEWaite merged commit 4ebb6e4 into jenkinsci:master Sep 18, 2024
17 checks passed
@MarkEWaite MarkEWaite deleted the use-non-deprecated-jgit-methods branch September 18, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces maintenance effort by changes not directly visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant