Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional mountPaths and logging file paths for config reload container #1143

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

jesrig
Copy link
Contributor

@jesrig jesrig commented Jul 7, 2024

What does this PR do?

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

@jesrig jesrig requested a review from a team as a code owner July 7, 2024 03:08
@jesrig
Copy link
Contributor Author

jesrig commented Jul 9, 2024

@kvanzuijlen
I am a first time contributor to this helm chart, can you help me understand what I need to do to fix this PR?
When ran into this linting error locally, I manually deleted the __snapshot__ folder, ran ct lint --config ct.yaml and it passed. I then commited the changes to __snapshot__ as part of my PR.

Please advise.

@kvanzuijlen
Copy link
Contributor

@jesrig I'll try to take a look later today

@jesrig
Copy link
Contributor Author

jesrig commented Jul 11, 2024

@kvanzuijlen All checks now passed, and I believe I addressed all of your comments. If you could re-review, that would be great.

@timja timja merged commit bbb26c9 into jenkinsci:main Jul 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add capability to include custom volume mounts on config reload container
4 participants