Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor kubernetes config #803

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

SylivanKenobi
Copy link
Contributor

What this PR does / why we need it

The goal of this PR is to start a discussion about how feature toggles should be handled especially controller.JCasC.defaultConfig. In my opinion the current feature toggles have too many unclear consequences. If I disable the controller.JCasC.defaultConfig doesn't mean I want to disable agent It's not in the same subtree it shouldn't have an impact. Furthermore if I disable agent.enabled I would assume that all keys underneath it would be disabled but that isn't the case.

This changes in this PR are a proposal and aren't final.

I would be glad for your input:
@maorfr
@torstenwalter
@mogaal
@wmcdona89
@timja

Which issue this PR fixes

Special notes for your reviewer

Checklist

  • DCO signed
  • Chart Version bumped
  • CHANGELOG.md was updated

@SylivanKenobi
Copy link
Contributor Author

Any input on this?
@maorfr
@torstenwalter
@mogaal
@wmcdona89
@timja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Agent config get's ignored if defaultConfig is disabled
1 participant