Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

884 - Adding common labels #885

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

psimms-r7
Copy link

@psimms-r7 psimms-r7 commented Jun 19, 2023

What does this PR do?

  • Adding a common labels helper and replacing labels with this helper
  • Adding additional labels app.kubernetes.io/part-of and app.kubernetes.io/version
  • Bump chart version

Deployed out to eks cluster and confirmed labels

#884

  • Fixes #

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Special notes for your reviewer

@psimms-r7 psimms-r7 requested a review from a team as a code owner June 19, 2023 17:25
@psimms-r7
Copy link
Author

Need to look at unit tests

@psimms-r7
Copy link
Author

Not 100% on how to fix the last 2 unit test issues
Tests
jcasc-config-test.yaml
secret-claims-test.yaml

app.kubernetes.io/part-of: {{ .Chart.Name }}
app.kubernetes.io/instance: {{ .Release.Name }}
app.kubernetes.io/version: {{ include "controller.tag" . }}
{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also be able to define custom common labels via values.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants