Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving DRY principle support on Jenkins Controller Ingress host name #908

Merged
merged 9 commits into from
Sep 8, 2023

Conversation

Ceddaerrix
Copy link
Contributor

What does this PR do?

Improving DRY principle support on Jenkins Controller Ingress host name

  • Fixes #

Submitter checklist

  • Introducing TPL function on variables related to hostname in ./charts/jenkins/templates/jenkins-controller-ingress.yaml

Special notes for your reviewer

The change is intending to support the following syntax in a values.yaml such as:

global:
  jenkinsHostname: "jenkins.my-org.com"

controller:
  ingress:
    enabled: true
    hostName: "{{ .Values.global.jenkinsHostname }}"
    resourceRootUrl: "{{ .Values.global.jenkinsHostname }}"
    tls:
      - hosts:
        - "{{ .Values.global.jenkinsHostname }}"

@Ceddaerrix Ceddaerrix requested a review from a team as a code owner September 1, 2023 09:58
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you take a look at the build failure please?

@Ceddaerrix
Copy link
Contributor Author

can you take a look at the build failure please?

Failure fixed: it was missing a chart version increment

Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changelog too

@Ceddaerrix
Copy link
Contributor Author

changelog too

Done with version increment to 4.6.4

@timja timja merged commit a451626 into jenkinsci:main Sep 8, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants