Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support retentionTimeout and waitForPodSec #923

Merged
merged 6 commits into from
Oct 23, 2023
Merged

Conversation

AhmadMasry
Copy link
Contributor

@AhmadMasry AhmadMasry commented Sep 29, 2023

What does this PR do?

Add the ability to modify retentionTimeout and waitForPodSec default value in JCasC:

  • retentionTimeout: For tasks that use very large images, this timeout can be increased to avoid early termination of the task while the Kubernetes pod is still deploying.
  • waitForPodSec: This will change how long Jenkins will wait (seconds) for pod to be in running state.

Submitter checklist

@AhmadMasry AhmadMasry requested a review from a team as a code owner September 29, 2023 17:37
@AhmadMasry
Copy link
Contributor Author

Is there anything I can do to fix the tests or to go forward?
Thank you

charts/jenkins/README.md Outdated Show resolved Hide resolved
@timja
Copy link
Member

timja commented Oct 22, 2023

Is there anything I can do to fix the tests or to go forward? Thank you

You need to update the checksums, the new ones are in the logs, search the string that is failing in the test and replace it with the new one

@AhmadMasry
Copy link
Contributor Author

@timja Thank you for you review.
I fixed your suggestion and fixed all tests.

@timja timja merged commit 3ad4aca into jenkinsci:main Oct 23, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants