Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving unit test coverage over DRY support #941

Open
wants to merge 46 commits into
base: main
Choose a base branch
from

Conversation

Ceddaerrix
Copy link
Contributor

@Ceddaerrix Ceddaerrix commented Nov 7, 2023

What does this PR do?

  • This PR is about introducing the unit test that was discarded under PR 929 assuming some of the limitations of the matchRegex assert in Helm-unittest

If you modified files in the ./charts/jenkins/ directory, please also include the following:

Submitter checklist

Special notes for your reviewer

…ss-DRY-test.yaml

Due to limitation in helm-unittest about validating a YAML content into a string field,  the test case on jcasc-config.yaml is momentarily commented.

Nonetheless, a visual validation of https://github.com/jenkinsci/helm-charts/actions/runs/6493066967/job/17633246976?pr=929 actual value shows 'unclassified.location.url' = "https://jenkins.example.com" as expected (https://github.com/jenkinsci/helm-charts/actions/runs/6493066967/job/17633246976?pr=929#step:8:131)
@Ceddaerrix Ceddaerrix requested a review from a team as a code owner November 7, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants