Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-71021] Lint failures do not print proper error message in local builds (regression in 2.359) #9761

Merged
merged 6 commits into from
Sep 22, 2024

Conversation

basil
Copy link
Member

@basil basil commented Sep 19, 2024

See JENKINS-71021.

Amending the Maven profile changes from #9718 which appear to have been completely untested prior to integration.

Testing done

Introduced stylelint and eslint failures in both CI and local builds.

Proposed changelog entries

N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@basil basil added the skip-changelog Should not be shown in the changelog label Sep 19, 2024
@basil basil changed the title Jenkins 71021 [JENKINS-71021] Lint failures do not print proper error message in local builds (regression in 2.359) Sep 19, 2024
@basil basil marked this pull request as ready for review September 19, 2024 19:49
@basil basil added the squash-merge-me Unclean or useless commit history, should be merged only with squash-merge label Sep 19, 2024
<execution>
<id>yarn lint</id>
Copy link
Member Author

@basil basil Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear why there were three linting executions; there is only a need for two (one for CI, and one for local builds). Deleted the unnecessary execution and moved the two necessary executions to the correct place in the file (after the build executions, reflecting the order of operations at runtime).

<goals>
<goal>yarn</goal>
</goals>
<phase>test</phase>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@github-actions github-actions bot added the unresolved-merge-conflict There is a merge conflict with the target branch. label Sep 22, 2024
Copy link
Contributor

Please take a moment and address the merge conflicts of your pull request. Thanks!

@github-actions github-actions bot removed the unresolved-merge-conflict There is a merge conflict with the target branch. label Sep 22, 2024
@basil basil merged commit 06a211f into jenkinsci:master Sep 22, 2024
16 checks passed
@basil basil deleted the JENKINS-71021 branch September 22, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-changelog Should not be shown in the changelog squash-merge-me Unclean or useless commit history, should be merged only with squash-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants