Correctly iterate IComputers from ComputerSet/index.jelly

[jglick]

#9749 updates the executors widget to display the new list of IComputers, but the nodes overview pages was forgotten. get_all only returns the old list of Computers.

Testing done

Tested interactively and with an automated test in CloudBees CI.

Proposed changelog entries

• N/A

Proposed upgrade guidelines

N/A

Before the changes are marked as ready-for-merge:

Maintainer checklist

Beta Give feedback

1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
4. Proper changelog labels are set so that the changelog can be generated automatically.
5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).

[MarkEWaite]

Thanks! I assume this is skip-changelog because the issue is not visible to a typical Jenkins user. I was unable to see any issue on my installation of Jenkins 2.480 when viewing the list at /computer/.

[MarkEWaite]

@jglick, thanks for the pull request. I've inserted the "Proposed upgrade guidelines" section so that the changelog generator will provide the correct changelog entry from the pull request description. If you could retain that section in future pull requests, it would avoid me needing to edit the changelog description.

[Vlatombe]

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

[jglick]

I assume this is skip-changelog because the issue is not visible to a typical Jenkins user.

Correct, this can only affect CloudBees CI (in HA mode) where there are IComputers which are not instanceof Computer.

I've inserted the "Proposed upgrade guidelines" section so that the changelog generator will provide the correct changelog entry from the pull request description. If you could retain that section in future pull requests

Oops, sorry, was not aware.

[timja]

I've inserted the "Proposed upgrade guidelines" section so that the changelog generator will provide the correct changelog entry from the pull request description. If you could retain that section in future pull requests

Oops, sorry, was not aware.

I don't think it will matter for a skip-changelog but in general leave all sections of the PR template in place 👍 .