Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure NodeListener#onCreated is called once the Node initialization is complete #9964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Vlatombe
Copy link
Member

@Vlatombe Vlatombe commented Nov 12, 2024

Amends #9905

Without this change, when an implementation of NodeListener#onCreated attempts to use a method like Node#getRootDir, it fails because the Node object is not fully initialized.

Not mentioning this in changelog as the possible usage of this is too specific to be relevant.

See JENKINS-XXXXX.

Testing done

Proposed changelog entries

  • N/A

Proposed upgrade guidelines

N/A

Submitter checklist

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

@Vlatombe Vlatombe added bug For changelog: Minor bug. Will be listed after features skip-changelog Should not be shown in the changelog and removed bug For changelog: Minor bug. Will be listed after features labels Nov 12, 2024
@Vlatombe Vlatombe requested a review from jglick November 12, 2024 15:48
@Vlatombe Vlatombe requested a review from a team November 13, 2024 09:30
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants