Add Jira Issue update step to pipeline

[aatarasoff]

Similar as JiraIssueUpdateBuilder, but for pipeline

---

This change is

[coveralls]

Coverage increased (+0.5%) to 48.215% when pulling 69621d8 on aatarasoff:pipeline-jira-issue-updater into a79b0fd on jenkinsci:master.

[oleg-nenashev]

Looks good to me as a code.
But I'm not sure what's the problem with the original JiraIssueUpdateBuilder. It implements SimpleBuildStep, hence it should be available in Pipeline

[aatarasoff]

I don't know how builder will look in pipeline, but I think that notation like:

jiraIssueUpdate(
  jqlSearch: jql,
  workflowActionName: action,
  comment: "Some comment"
)

is really easier for use. Could you provide an example with JiraIssueUpdateBuilder?
And in pipeline syntax help I didn't see this builder.

[aatarasoff]

Add new pipeline steps. One for updating issue field and one for strict workflow process, cause issue updater set build only Unstable, but not Failure.

[coveralls]

Coverage increased (+1.0%) to 48.712% when pulling da4fac3 on aatarasoff:pipeline-jira-issue-updater into a79b0fd on jenkinsci:master.

[rantoniuk]

Please add class description

[rantoniuk]

I'll take a look at this tomorrow because it looks like some of the code is duplicated from the original JiraIssueUpdateBuilder class which as @oleg-nenashev pointed out should be usable already as a Pipeline step.
On the other hand, I would warmly welcome the IssueFieldUpdateStep functionality as a separate PR!

[artkoshelev]

can you please replace wildcard imports?

[rantoniuk]

I'm assuming this is an automatic IDE feature (in IDEA) replacement, that when > 5 imports, wildcards are automatically incurred. Personally this is still debatable for me:
http://stackoverflow.com/questions/147454/why-is-using-a-wild-card-with-a-java-import-statement-bad
Any good reason in Jenkins case about not using wildcard imports that we should maybe put in the README guidelines?

[artkoshelev]

i just looked through few random classes in jenkins core repo and can't see wildcard imports used. it would be better to add checkstyle plugin to build rather than put it in README

[z00dev]

Please finish work on this so it can be merged, it would enable pipelines for our organization. This is the missing step.

[rantoniuk]

@eskobaba what about #101 (comment)? did you try this one?

[z00dev]

I need pipeline compatibility to post a value to a customfield
Have i overlooked something?

[rantoniuk]

@aatarasoff

I don't know how builder will look in pipeline, but I think that notation like:

jiraIssueUpdate(
  jqlSearch: jql,
  workflowActionName: action,
  comment: "Some comment"
)

is really easier for use. Could you provide an example with JiraIssueUpdateBuilder?
And in pipeline syntax help I didn't see this builder.

This argument is quite convincing for me, but this PR needs a rebase.
Would you have some time for it? if not, I'll try to take it over.

[rantoniuk]

@aatarasoff are you still using this construct? if so, could you rebase it to the current version?