Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jenkins-68742] Fixed Job Config History Badge Link Visibility #352

Merged
merged 5 commits into from
Jan 12, 2025

Conversation

code-arnab
Copy link
Contributor

Testing done

Closes

Modified the visibility of the link of the Job Config Badge Link. Previously anyone can click on the Job Config Badge Link if the badge was visible. Now, the link can only be accessible if user have job config permission. Refer to this

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@code-arnab code-arnab requested a review from a team as a code owner January 11, 2025 06:41
@code-arnab code-arnab marked this pull request as draft January 11, 2025 06:53
@code-arnab code-arnab marked this pull request as ready for review January 11, 2025 07:04
@code-arnab
Copy link
Contributor Author

Hello @NotMyFault can you please review this

@code-arnab
Copy link
Contributor Author

Hello @StefanSpieker can you also review these changes

@StefanSpieker
Copy link
Contributor

@code-arnab Yes, already on it. Thanks by the way!

@code-arnab
Copy link
Contributor Author

Great! Thank you

Copy link
Contributor

@StefanSpieker StefanSpieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks wonderful, thanks a lot. Just a minor thing would be to replace title with tooltip, since title is deprecated.

Changed "title" to "tooltip"
@code-arnab
Copy link
Contributor Author

Looks wonderful, thanks a lot. Just a minor thing would be to replace title with tooltip, since title is deprecated.

Thank You, for the review just changed title to tooltip

@StefanSpieker StefanSpieker merged commit 961ab70 into jenkinsci:master Jan 12, 2025
17 checks passed
@code-arnab
Copy link
Contributor Author

Thank you 👍

@code-arnab
Copy link
Contributor Author

I've marked the issue as resolved in JIRA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants