-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Jenkins-68742] Fixed Job Config History Badge Link Visibility #352
[Jenkins-68742] Fixed Job Config History Badge Link Visibility #352
Conversation
Hello @NotMyFault can you please review this |
src/main/java/hudson/plugins/jobConfigHistory/JobConfigHistory.java
Outdated
Show resolved
Hide resolved
Hello @StefanSpieker can you also review these changes |
@code-arnab Yes, already on it. Thanks by the way! |
Great! Thank you |
src/main/resources/hudson/plugins/jobConfigHistory/JobConfigBadgeAction/badge.jelly
Outdated
Show resolved
Hide resolved
src/main/resources/hudson/plugins/jobConfigHistory/JobConfigBadgeAction/badge.jelly
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks wonderful, thanks a lot. Just a minor thing would be to replace title
with tooltip
, since title is deprecated.
Changed "title" to "tooltip"
Thank You, for the review just changed |
Thank you 👍 |
I've marked the issue as resolved in JIRA. |
Testing done
Closes
Modified the visibility of the link of the Job Config Badge Link. Previously anyone can click on the Job Config Badge Link if the badge was visible. Now, the link can only be accessible if user have job config permission. Refer to this
Submitter checklist