Add color configuration of trend chart (show passed tests in green or blue ) #286
Conversation
Additionally, trend charts are now configurable due to an upgrade to the echarts plugin.
It is not required to retain backward compatibility for restricted classes.
Now the general trend options are changed for *all* charts. So individual trend chart dialogs change the global configuration and the local one.
Now configuration of trend charts in job page and trend charts in details pages use a different dialog.
The new configuration option allows choosing green or blue as color for passed tests. Additionally, the stacked chart series have been reordered so that the passed tests come first. Then the automatic axis scaling of ECharts works as expected and shows only the important chart part.
|
Nice we could probably change the default colour to green? |
Yes, absolutely. This makes more sense for JUnit results (and the build success status is green anyway). |
|
Some conflicts from the history bug fixes btw. |
|
Yes, I also need to clean up the patch, I forgot to disable IntelliJ's new on save actions. I will do this after the #272 has been merged. |
sure, unlikely code will change much in this area now so any patch should be stable |
# Conflicts: # pom.xml # src/main/java/hudson/tasks/junit/History.java # src/main/java/hudson/tasks/test/TestResultDurationChart.java # src/main/java/hudson/tasks/test/TestResultProjectAction.java # src/main/java/hudson/tasks/test/TestResultTrendChart.java # src/main/resources/hudson/tasks/junit/History/index.jelly # src/main/resources/hudson/tasks/test/TestResultProjectAction/floatingBox.jelly # src/main/webapp/history/history.css # src/main/webapp/history/history.js
|
I have no strong opinion. Swapping the default would not change the existing visualization, so it might be a better start. |
|
Ah actually this is the right way round, I just tested it out. Looks good |
The new configuration option allows choosing green or blue as color for passed tests:
Additionally, the stacked chart series have been reordered so that the passed tests come first.
Then the automatic axis scaling of ECharts works as expected and shows only the important chart part. In the screenshot below the x-Axis now starts at 500.
Here is a screenshot of the new layout:
This PR is an add-on for #272. I will rebase and cleanup this PR after #272 has been merged.