Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a new option to make the build UNSTABLE or not #98

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

nguoianphu
Copy link

Some people are looking for an option to make the JUnit plug doesn't make the build UNSTABLE even there're failed tests.

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary compatibility issues need to be resolved

pom.xml Outdated Show resolved Hide resolved
Copy link
Author

@nguoianphu nguoianphu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed @oleg-nenashev comments.

pom.xml Outdated Show resolved Hide resolved
@nguoianphu
Copy link
Author

Hi @oleg-nenashev

Can you take a look if I need to update anything else, plz? I can't resolve the build error on ci.jenkins.io :(

@amitSA
Copy link

amitSA commented Mar 24, 2020

+1 looking for this feature as my team has failing tests retried & reported, but we don't want the Junit plugin to set the build status.

I know this PR is old, but many thanks if it can be added!

@@ -46,4 +46,7 @@ THE SOFTWARE.
<f:entry title="${%Allow empty results}" field="allowEmptyResults">
<f:checkbox default="false" title="${%Do not fail the build on empty test results}"/>
</f:entry>
<f:entry title="${%Make the build UNSTABLE}" field="makeUnstable">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will fix it. Thanks

@RafaelloLoliop
Copy link

Oh I also need this one in my pipelines! I hope after 3 years it is still an option to finish this one!

@emanuelelevo
Copy link

https://github.com/nguoianphu/junit-plugin/pull/1/files

@timja
Copy link
Member

timja commented Oct 22, 2020

nguoianphu/junit-plugin#1 (files)

you can also submit it directly to this repo

@timja
Copy link
Member

timja commented Oct 26, 2020

Still needs conflict resolution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants