Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Command Palette #69

Draft
wants to merge 2 commits into
base: lucene-search
Choose a base branch
from

Conversation

janfaracik
Copy link

@janfaracik janfaracik commented Jul 22, 2024

As part of jenkinsci/jenkins#7569, Jenkins replaces the existing search input in the header for a Command Palette.

With this change the existing implementation of this plugin no longer works. jenkinsci/jenkins#7569 however introduces support for plugins adding their own buttons to the navigation bar. This has briefly been discussed as a workaround so that this plugin can still continue to work.

image

This draft MR introduces a new button to the navigation bar, currently called 'Lucene' which allows users to navigate to the existing Lucene search page. On that page a new search input has been introduced, allowing users to search with Lucene as they previously could.

image

Testing done

See #69 (comment)

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik
Copy link
Author

janfaracik commented Jul 22, 2024

Searching for nothing via the new search bar and old search bar

image

Searching for 'built' via the new search bar and old search bar
image

Searching for 'feat' inside of a job via the new search bar and old search bar
image

The above scenarios work the same - there might be scenarios I'm unaware of so do let me know if I've missed anything.

@janfaracik
Copy link
Author

Any thoughts on this @daniel-beck?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant