forked from lsjostro/prometheus-plugin
-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/516 add ignored metrics regexp option to ignore specific metrics based on regexp #542
Merged
Waschndolos
merged 8 commits into
master
from
feature/516-add-ignored-metrics-regexp-option-to-ignore-specific-metrics-based-on-regexp
Aug 26, 2023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/org/jenkinsci/plugins/prometheus/JobCollector.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/org/jenkinsci/plugins/prometheus/config/disabledmetrics/MetricStatusChecker.java
Dismissed
Show dismissed
Hide dismissed
src/main/java/org/jenkinsci/plugins/prometheus/config/disabledmetrics/RegexDisabledMetric.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Markdownlint (reported by Codacy) found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Waschndolos
deleted the
feature/516-add-ignored-metrics-regexp-option-to-ignore-specific-metrics-based-on-regexp
branch
August 26, 2023 13:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #516
Changes proposed
Adding configuration which enables the user to disable certain metrics
Checklist