Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JENKINS-57921] - Add SelfPromotionStep for Pipeline jobs #132

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[JENKINS-57921] - Add SelfPromotionStep for Pipeline jobs #132

wants to merge 1 commit into from

Conversation

dernDren161
Copy link
Contributor

@dernDren161 dernDren161 commented Jun 12, 2019

See JENKINS-57921.

Your checklist for this pull request

  • Pull request title represents the changelog entry which will be used in Release Notes. JIRA issue is a part of the title (see existing PRs as examples)
  • Please describe what you did. Short summary for reviewers. If the change involves WebUI, add screenshots
  • Link to relevant Jenkins JIRA issues or pull requests
  • Test automation, if relevant. We expect autotests for all new features or complex bugfixes
  • Documentation if relevant (new features). We want to use Documentation-as-Code, just put docs to README or to new Doc files
  • Javadoc for new APIs. Any public/protected method is considered as API unless annotated by Restricted (docs)

CC

@oleg-nenashev @bicschneider @MadsNielsen @jonbrohauge @jenkinsci/gsoc2019-promotion-for-pipeline

I am confused about the StepExecution start() method as to what goes inside Execution. Is it that we put our SelfPromotionCondition in this Execution Class ? Would this be the way how the DSL would call SelfPromotionCondition ?

Downstream of #131. Needs foundation logic

https://issues.jenkins-ci.org/browse/JENKINS-57921

Thank You!

@oleg-nenashev
Copy link
Member

oleg-nenashev commented Jun 12, 2019 via email

@oleg-nenashev oleg-nenashev changed the title About the SelfPromotionStep [JENKINS-57921] - Add SelfPromotionStep for Pipeline jobs Jun 12, 2019
@oleg-nenashev oleg-nenashev requested a review from a team June 12, 2019 10:08
@jonbrohauge
Copy link

jonbrohauge commented Jun 12, 2019

Updated description to adhere to PR-template.
TODO: Fill in the relevant data in their respective fields

DONE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants