Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipeline stars #139

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

deathrowe
Copy link

@oleg-nenashev,

My work just had a hackathon last week and I decided to take a stab at this. I was able to get this to work (as far as I know!) but I didn't do much testing as I was able to get things to show up in the UI which was good enough for me to submit a video for and do a demo with. I'm not sure if this will help you at all but I figured I would make you aware as you or someone else is currently trying to implement this.

Feel free to do what you want with this PR but I don't really expect much to come from it.

Thanks!

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @deathrowe, thanks for the pull request! FYI there is some ongoing effort to make the plugin compatible without massive binary incompatible changes (like ones in this PR). We had a GSoC project this year, but unfortunately it was not successful. You can see some pull requests and Jenkins JIRA references in the code.

My plan is to gradually land these changes though it will take a while. If you are interested to contribute, please join the Gitter channel so that we can coordinate the effort

@patrickjamesbarry
Copy link

Wow, we have been waiting for this for a while! Looks like all tests passed with these new changes. What do you mean by "massive binary incompatible changes" that would prevent these changes from being accepted?

@oleg-nenashev
Copy link
Member

Breaking changes... Pretty much everything starting from public final class JobPropertyImpl extends JobProperty<Job<?,?>> implements ItemGroup<PromotionProcess>) (AbstractProject => Job change). https://wiki.eclipse.org/Evolving_Java-based_APIs_2

@oleg-nenashev
Copy link
Member

FTR a link to the GSoC project we had this year: https://jenkins.io/projects/gsoc/2019/artifact-promotion-plugin-for-jenkins-pipeline/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants