-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-55595] Configuration as code support #118
base: master
Are you sure you want to change the base?
Conversation
@Jimilian could you have a look at this? |
I suggest to also implement an import from YAML and export to YAML test. See the official documentation for implementing these here. |
Not sure the status of this, but I would love to see this PR merged. Is there a timeline on for this project in merging all this stuff? Trying to eliminate all the manual config setup for our Jenkins and this is one of the items on the list. So glad to see a solution waiting when I checked on here. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is not going to work as is unfortunately. The persistency model is being changed without retaining compatibility. If the data type needs to be changes to make the code compatible with JCasC, there should be a graceful data migration imho
Hi @oleg-nenashev , thanks for the feedback. Actually, I'm not sure how to proceed. Can you point me into the right direction? |
In the meantime you can use workaround by writing initscript.
|
What's the status of this? The lack of casc support for this plugin is kind of a deal breaker for us. |
I'm still happy to do the changes, but to be honest I don't know what's needed. @oleg-nenashev I have to admit that I didn't fully understand your comment. So you're saying that I cannot change the List implementation as it creates incompatibility. The reason I changed it was that there was no configurator for CopyOnWriteList. How difficult would it be to implement the configurator? Wouln't that be a preferred solution? |
Sorry, I missed your previous comment. Added it to my review queue |
No problem. I know that maintaining something is hard. Thanks for doing this! :) |
@Holmistr Just came here to check if there had been any progress on this and it appears you have a merge conflict here now |
@sanga I'm waiting for @oleg-nenashev 's answer on the comment #118 (comment) . |
@oleg-nenashev @Holmistr sorry for just tagging you guys, but was wondering if there is any updates? |
Unfortunately not from my side :-( |
Is there any update on this PR? |
@HatsuneMiku3939 Nothing from my side. I'm still happy to adapt the PR but I need some support from the Jenkins side. On the other hand, it's no longer a priority for me, so I'm not actively pushing for it. If you get the info "what should be done", I'm happy to do it :) |
@Holmistr Thanks for your effort. I understand the current situation. |
Hello, how is the queue going? :) In the mean time, is there a way to configure this using DSL? I can't find anything useful in Thanks! |
https://issues.jenkins-ci.org/browse/JENKINS-55595
I had to change the list implementation because there was no configurator for CopyOnWriteList. Anyway, I don't see why it should be used, but perhaps I'm missing something. Feel free to point me to the right direction.