Skip to content

Commit

Permalink
Fix JenkinsWhitelistTest on 2.477 incremental (#578)
Browse files Browse the repository at this point in the history
* Test with Jenkins 2.477-rc35350.7ff5a_a_a_0fdc3 incremental

The JenkinsWhitelistTest will fail because

  method hudson.model.Run getFullDisplayName does not exist (or is an override)

Show the test failure on ci.jenkins.io,

* Exclude hudson.model.Run.getFullDisplayName from sanity test

An override in Jenkins 2.477

* Revert "Test with Jenkins 2.477-rc35350.7ff5a_a_a_0fdc3 incremental"

This reverts commit 9f3bad4.
  • Loading branch information
MarkEWaite authored Sep 16, 2024
1 parent 9131007 commit 67dc1f0
Showing 1 changed file with 4 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,10 @@ static void sanity(URL definition) throws Exception {
new MethodSignature(MatchResult.class, "hasMatch"),
new MethodSignature(MatchResult.class, "namedGroups"),
new MethodSignature(MatchResult.class, "start", String.class),
// TODO No longer exists after Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674

Check warning on line 159 in src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO

NORMAL: No longer exists after Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674
// Remove once plugin depends on Jenkins 2.477 or newer
// Remove from jenkins-whitelist at the same time
new MethodSignature("hudson.model.Run", "getFullDisplayName"),
// TODO Do not exist until Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674

Check warning on line 163 in src/test/java/org/jenkinsci/plugins/scriptsecurity/sandbox/whitelists/StaticWhitelistTest.java

View check run for this annotation

ci.jenkins.io / Open Tasks Scanner

TODO

NORMAL: Do not exist until Jenkins includes https://github.com/jenkinsci/jenkins/pull/9674
new MethodSignature("jenkins.model.HistoricalBuild", "getFullDisplayName")
));
Expand Down

0 comments on commit 67dc1f0

Please sign in to comment.