[JENKINS-30141] Option to choose if depth is sticky #134
Conversation
User can choose the desired behavior now (like --depth and --set-depth flags in svn)
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
recena
changed the title
| } | ||
|
|
||
| @DataBoundConstructor | ||
| public ModuleLocation(String remote, String credentialsId, String local, String depthOption, boolean ignoreExternalsOption) { | ||
| public ModuleLocation(String remote, String credentialsId, String local, String depthOption, boolean stickyDepth, boolean ignoreExternalsOption) { |
There was a problem hiding this comment.
binary compatibility issue. It's better to keep and deprecate the original constructor
There was a problem hiding this comment.
Thank you! I'm quite new to Java :-)
I've pushed a fix commit to my repository. Now, how is it customary to
proceed in such cases? Shall I open a new pull request?
On Wed, Sep 9, 2015 at 12:32 PM, Oleg Nenashev [email protected]
wrote:
In src/main/java/hudson/scm/SubversionSCM.java
#134 (comment)
:} @DataBoundConstructor
public ModuleLocation(String remote, String credentialsId, String local, String depthOption, boolean ignoreExternalsOption) {public ModuleLocation(String remote, String credentialsId, String local, String depthOption, boolean stickyDepth, boolean ignoreExternalsOption) {binary compatibility issue. It's better to keep and deprecate the original
constructor—
Reply to this email directly or view it on GitHub
https://github.com/jenkinsci/subversion-plugin/pull/134/files#r39023278.
| @@ -51,6 +51,9 @@ THE SOFTWARE. | |||
| <f:option value="unknown" selected="${instance.depthOption=='unknown'}">as-it-is</f:option> | |||
| </select> | |||
| </f:entry> | |||
| <f:entry title="${%Make depth sticky}" field="stickyDepth"> | |||
There was a problem hiding this comment.
Could you also create a help file for this new option?
| @@ -0,0 +1,5 @@ | |||
| <div> | |||
| Choose if <tt>--set-depth</tt> (sticky) or <tt>--depth</tt> (non-sticky) option should be used for switch and update commands. Default value is sticky. | |||
| More information can be found | |||
There was a problem hiding this comment.
@vvv444 Please, use <code> instead of <tt>. I'll try to merge this PR soon.
|
Please note the check failed due to some timeout problem. Not because of my code. How can I rerun it? |
|
@vvv444 close and open the PR. |
|
@recena @oleg-nenashev Hey guys, any reason why this wasn't integrated? |
|
@vvv444 Yes, I'm avoiding to include new features until we improve our test coverage and solve bugs related to |
|
I would also prefer to avoid new features unless they are obviously self-contained like |
|
Hey guys, any ETA on when will this feature be integrated ? |
|
Somebody need to resolve the merge conflict |
https://issues.jenkins-ci.org/browse/JENKINS-30141
User can choose the desired behavior now (like --depth and --set-depth flags in svn)