[JENKINS-73951][JENKINS-73952] Improve CSP compatibility

[yaroslavafenkin]

https://issues.jenkins.io/browse/JENKINS-73951
https://issues.jenkins.io/browse/JENKINS-73952

Testing done

For JENKINS-73951 I needed to go to the enterCredential page that's referenced from url field help file. And then to get to the credentialOK I commented out these lines locally:

subversion-plugin/src/main/java/hudson/scm/SubversionSCM.java

Lines 2347 to 2348 in c73117e

	repository.testConnection();
	authManager.checkIfProtocolCompleted();

https://www.loom.com/share/4b2e8bfe5ab147e8b05584dded1343f1

https://www.loom.com/share/94b12cc934c8439f879bf5c8cc6709eb

CSP violations that appear in the list in the end are addressed by #319.

---

For JENKINS-73952 had to setup a project with 2 module locations, so that at least 2 entries appear on the tagBuild page which allows affected elements to be rendered. The functionality in the related script was broken due to jQuery not being available, so I've fixed that along the way.

https://www.loom.com/share/2b96f17fe29340ec8d536ebedbd9517e

https://www.loom.com/share/58b6fdaae7384c86bf9dd64b0ebe93f0

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests - that demonstrates feature works or fixes the issue

[basil]

Testing looks good. Left some optional feedback for your consideration. Feel free to disregard if these suggestions aren't helping.

[basil]

Elsewhere in your changes, you've been putting one-line lambdas into their own block. I don't care either way, as long as we're consistent within the same file.

Suggested change

	document.querySelector(".svn-credential-ok-close").addEventListener("click", () => window.close());
	document.querySelector(".svn-credential-ok-close").addEventListener("click", () => {
	window.close();
	});

[basil]

Elsewhere in Jenkins core and in other CSP PRs we're putting parameters in parentheses consistently, so please do so here as well:

Suggested change

	document.querySelectorAll(".svn-tagform-tag-checkbox").forEach(checkbox => {
	document.querySelectorAll(".svn-tagform-tag-checkbox").forEach((checkbox) => {

[yaroslavafenkin]

Thanks, I'll try to be more consistent with it.

[basil]

It seems odd to me that we aren't using checkbox. If it's truly unused, maybe we should use () instead on the previous line? Or if we should use it, should this line be:

Suggested change

	document.addEventListener("change", updateRow);
	checkbox.addEventListener("change", updateRow);

[yaroslavafenkin]

Oh, it's an oversight from my side. I'm unsure how this even worked for the sake of the video :/

[basil]

Thanks for the PR!