[JENKINS-14155] Make it possible to automatically select/build the latest svn tag #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pty and maxTags is 1. Also added unit test. Based on JENKINS-14155.
|
Jenkins » subversion-plugin #124 SUCCESS |
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
| @@ -138,6 +138,9 @@ public ParameterValue createValue(StaplerRequest req, JSONObject formData) { | |||
| @Override | |||
| public ParameterValue getDefaultParameterValue() { | |||
| if (StringUtils.isEmpty(this.defaultValue)) { | |||
| if ( isInt(this.maxTags) && Integer.parseInt(this.maxTags) == 1 ){ | |||
| return new ListSubversionTagsParameterValue(getName(), getTagsDir(), this.getTags().get(0)); | |||
There was a problem hiding this comment.
What if getTags() returns an empty list here (IndexOutOfBoundException)? Can that happen?
|
Merge conflicts. Anyway this plugin needs a lot of cleanup before new features will be considered, unless they are clearly self-contained. |
|
Is #157 the same use case? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we are able to build the last tag matching the filters set. For that you need to: