JENKINS-5347 Fixed - Added use commit times on files #64
Conversation
This fixes JENKINS-5347, we have a third party tool that uses the timestamp on files to notify a cache in the tool to be updated. This fix will add an option to the Subversion configuration to use commit times. As the "use-commit-times" is a global configuration but we are only interested in it as a per-project configuration to not affect our other builds.
|
plugins » subversion-plugin #302 UNSTABLE |
Apparently there is some Timezone issues when running the tests on my and the cloudbees machine. Have reverted the last modified assertion to a simple long assertion.
|
plugins » subversion-plugin #303 UNSTABLE |
It seems that the file.lastmodified() is different depending on the OS. Some OS'es return the exact milliseconds while some doesnt. This fixes the test so they work both on both type of OSes
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
plugins » subversion-plugin #304 UNSTABLE |
|
Not sure, why the build is unstable. Im getting the same errors when compiling master branch of jenkins-ci/subversion-plugin (without this pull request) |
| @@ -357,7 +358,7 @@ public SubversionSCM(List<ModuleLocation> locations, WorkspaceUpdater workspaceU | |||
| public SubversionSCM(List<ModuleLocation> locations, WorkspaceUpdater workspaceUpdater, | |||
| SubversionRepositoryBrowser browser, String excludedRegions, String excludedUsers, String excludedRevprop, String excludedCommitMessages, | |||
| String includedRegions, boolean ignoreDirPropChanges) { | |||
| this(locations, workspaceUpdater, browser, excludedRegions, excludedUsers, excludedRevprop, excludedCommitMessages, includedRegions, ignoreDirPropChanges, false, null); | |||
| this(locations, workspaceUpdater, browser, excludedRegions, excludedUsers, excludedRevprop, excludedCommitMessages, includedRegions, ignoreDirPropChanges, false, null, false); | |||
There was a problem hiding this comment.
You're supposed to add another constructor for backwards compatibility instead of modifying an existing one. (This is why there are so many deprecated ones with fewer arguments)
This fixes JENKINS-5347, we have a third party tool that uses the
timestamp on files to notify a cache in the tool to be updated. This fix
will add an option to the Subversion configuration to use commit times.
As the "use-commit-times" is a global configuration but we are only
interested in it as a per-project configuration to not affect our other
builds.