Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to use UTC-formatted time when using BUILD_DATE_FORMATTED #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Blackbaud-MikeLueders
Copy link

Eliminates potential non-increasing build numbers when using BUILD_DATE_FORMATTED caused by daylight savings time

@jenkinsadmin
Copy link
Member

Thank you for this pull request! Please check this document for how the Jenkins project handles pull requests.

@DenizThatMenace
Copy link
Contributor

Your pull-request looks good except for some minor typos. (I added comments above.)

However, I fear the result might be a little surprising in some cases.

In particularly, if BUILD_DATE_FORMATTED is used along with e.g. BUILD_DAY or BUILDS_TODAY the output might not be what one expects if your "UTC" option is set.
The formatted build-date shows the UTC-time, while the current "build day" and the "number of builds today" use the local time and therefore display wrong values regarding the UTC-time.

Therefore, I would recommend, you change your pull-request (or provide a new one), so that setting the UTC-option has correct impact on all variables, not only on BUILD_DATE_FORMATTED.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants