Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added BUILD_DAY_OF_YEAR support #18

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added BUILD_DAY_OF_YEAR support #18

wants to merge 2 commits into from

Conversation

ctacke
Copy link

@ctacke ctacke commented Jan 27, 2017

No description provided.

@DenizThatMenace
Copy link
Contributor

Hi @ctacke ,
although this looks like a simple change, two thingst are missing before this pull-request can be accepted.

  1. Some help/documentation.
    Probably you should extend the help-message for the Version Number Format String text-field.
  2. Tests
    Please add a test which explicitly tests the new variable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ctacke @DenizThatMenace @gounthar