[APM][OTel] Ensure Errors views works with OTel Data #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmyz
changed the base branch from
main
to
192606-poc-otel-data-with-apm-ui-replacing-_source-with-fields
|
/ci |
rmyz
changed the title
rmyz
changed the title
rmyz
changed the title
| @@ -66,16 +67,18 @@ export async function getErrorGroupSampleIds({ | |||
| should: [{ term: { [TRANSACTION_SAMPLED]: true } }], // prefer error samples with related transactions | |||
| }, | |||
| }, | |||
| _source: [ERROR_ID, 'transaction'], | |||
| fields: [ERROR_ID], | |||
There was a problem hiding this comment.
If I'm not mistaken, the 'transaction' was added for the scoring, so I think the field TRANSACTION_SAMPLED, should we also added not sure why just 'transaction' was in this case
@dgieselaar can you confirm?
miloszmarcinkowski
approved these changes
Oct 4, 2024
Comment on lines
169
to
172
| culprit: normalizedFields?.error?.culprit, | ||
| handled: normalizedFields?.error?.exception[0]?.handled, | ||
| type: normalizedFields?.error?.exception[0]?.type, | ||
| traceId: normalizedFields?.trace?.id, |
There was a problem hiding this comment.
nit: Optional chaining is only needed for normalizedFields. If the object is not undefined, then the rest is defined
Suggested change
| culprit: normalizedFields?.error?.culprit, | |
| handled: normalizedFields?.error?.exception[0]?.handled, | |
| type: normalizedFields?.error?.exception[0]?.type, | |
| traceId: normalizedFields?.trace?.id, | |
| culprit: normalizedFields?.error.culprit, | |
| handled: normalizedFields?.error.exception[0].handled, | |
| type: normalizedFields?.error.exception[0].type, | |
| traceId: normalizedFields?.trace.id, |
|
This work will be merged on elastic#195242 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Closes elastic#192336
Kapture.2024-10-04.at.15.52.06.mp4
How to test
*otel*indices.error.exception.handled:trueto see failing services