Minor enhancement to read hdf5 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeonggyukim
reviewed
Aug 16, 2023
pyathena/load_sim.py
Outdated
| Examples | ||
| -------- | ||
| >>> # Load everything at snapshot number 30. | ||
| >>> ds = read_hdf5(30) |
There was a problem hiding this comment.
Shouldn't the first argument be the filename? Something like this:
from pyathena.io import read_hd5
ds = read_hdf5(s.files['hdf5']['prim'], 30)There was a problem hiding this comment.
Correct. Thanks for catching this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
header_onlyoptional parameter allows reading only the domain information (including snapshot time), without loading actual data.load_hdf5function to demonstrate we can load e.g., only the selected field through the keywords argumentsquantitiesor only the selected region throughx1_min,x1_max, etc. that are passed toathdffunction.util.transform.to_sphericalmore flexible by allowing arbitrary "z-axis" of the spherical coordinates.