New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Units class takes units_dict for tigris or custom unit systems. #31

Merged

jeonggyukim merged 1 commit into master from unit-improve

Feb 13, 2024

Owner

jeonggyukim commented Feb 8, 2024 •

edited

Loading

For tigris simulations, the mass unit for "ism" unit system was set incorrectly (off by a factor 1.4).

Improved Units class so that it can take kind="custom" argument (used for tigris simulations). In this case, units_dict should be provided (same as <units> block in athinput).
Improved documentation.

Possible future improvements:

Can implement Units class as dataclass and make it immutable.


          Units class takes units_dict for tigris or custom unit systems.

a0cac32

jeonggyukim added the bug label

jeonggyukim requested a review from sanghyukmoon

February 8, 2024 08:33

jeonggyukim self-assigned this

jeonggyukim merged commit 3b569cc into master

1 check passed

jeonggyukim deleted the unit-improve branch

February 18, 2024 12:04

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug