Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a backward compatible way of getting random bytes #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonalmeida
Copy link

Should allow you to keep using an older version of OTP with rand_bytes/1 otherwise uses strong_rand_bytes/1

@jonalmeida
Copy link
Author

CI fails because of Reason: {badmatch,{error,{"no such file or directory","cowlib.app"}}}. I'm not sure how to fix that.

@sb8244
Copy link

sb8244 commented Jul 1, 2017

crypto.rand_bytes is deprecated in erlang/OTP 20. I believe that this PR fixes the error by using strong_rand_bytes. @jonalmeida have you been able to publish a module up that would fix this, or waiting for merge here?

@jonalmeida
Copy link
Author

@sb8244 Waiting for merge and/or someone to fix the CI build since it's not related to this.

@sb8244
Copy link

sb8244 commented Jul 1, 2017

Thanks for the update @jonalmeida. I'm still seeing some issues with the code that I'm trying to get working, although it could be related to that library and not this one. I actually see that websocket_client master has the strong_rand_bytes which is what I needed (not backwards compat)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants