fix space leak by including writing out shrunken images in parallelized operation #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed operation as discussed in the comment, the old approach would hold all shrunken images in memory at once, before writing any of them to disk. the new approach permits each shrunken image to be written to disk as soon as it's ready. this source of the space leak and the solution was suggested by claude.ai. fixes #98
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed in the comment, the old approach would hold all shrunken images in memory at once, before writing any of them to disk. the new approach permits each shrunken image to be written to disk as soon as it's ready.
this source of the space leak and the solution was suggested by claude.ai.
fixes #98