Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix TelephoneFormatter.php #200

Open
wants to merge 1 commit into
base: 2.0.0-dev
Choose a base branch
from
Open

Fix TelephoneFormatter.php #200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Formatter/Property/TelephoneFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,6 @@ public function getVcfString(): string
{
return $this->telephone->getNode() .
';TYPE=' . $this->telephone->getType()->__toString() .
';VALUE=' . $this->telephone->getValue() . ':tel:' . $this->telephone->getTelephoneNumber();
';VALUE=' . $this->telephone->getValue() . ';TEL:' . $this->telephone->getTelephoneNumber();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should stay tel in lowercase.
Becouse "tel" in this case is not the Node name from vCard https://datatracker.ietf.org/doc/html/rfc6350#section-6.4.1
It is the URI and the uri is defined here:
https://datatracker.ietf.org/doc/html/rfc3966

and there it is a lowercase tel

}
}