Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1384 - spike aggregation: TypeError: '<' not supported between instances of 'NoneType' and 'int' #1385

Closed
wants to merge 2 commits into from
Closed

Fix #1384 - spike aggregation: TypeError: '<' not supported between instances of 'NoneType' and 'int' #1385

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae97913
Fix spike aggregation exception: TypeError: '<' not supported between…
vaddenz Feb 28, 2024
4a84c00
Fix spike aggregation: TypeError: '<' not supported between instances…
vaddenz Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion elastalert/ruletypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -522,12 +522,15 @@ def add_match(self, match, qk):

def find_matches(self, ref, cur):
""" Determines if an event spike or dip happening. """
if ref is None or cur is None:
return False

# Apply threshold limits
if self.field_value is None:
if (cur < self.rules.get('threshold_cur', 0) or
ref < self.rules.get('threshold_ref', 0)):
return False
elif ref is None or ref == 0 or cur is None or cur == 0:
elif ref == 0 or cur == 0:
return False

spike_up, spike_down = False, False
Expand Down