Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Rails 7.2 #144

Merged
merged 2 commits into from
Aug 31, 2024
Merged

Support Rails 7.2 #144

merged 2 commits into from
Aug 31, 2024

Conversation

jgraichen
Copy link
Contributor

Add support for Rails 7.2 and a CI job for Ruby 3.3.

This MR expands the compatibility module to be included for Rails 7.2.

@jgraichen
feat: Support Rails 7.2
487d3b2
@jgraichen
fix: Load latest compat module by default
dacff05 
Unless the latest compatiblity module is loaded for any newer Rails
version, current Rails dev versions won't pass CI.

Fixes jesjos#140
@jgraichen jgraichen mentioned this pull request Aug 31, 2024
Closed
olleolleolle
olleolleolle approved these changes Aug 31, 2024
View reviewed changes
Copy link
Collaborator

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this thing.

@olleolleolle olleolleolle merged commit c3e07ae into jesjos:main Aug 31, 2024
14 checks passed
@jgraichen
Copy link
Contributor Author

@olleolleolle Can we get a new release?

@jgraichen jgraichen deleted the f/rails-7-2 branch October 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olleolleolle olleolleolle olleolleolle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgraichen @olleolleolle