Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cursor flickering when entering text inside of a tmux session #3434

Open
antmelon opened this issue Mar 25, 2024 · 7 comments
Open

Cursor flickering when entering text inside of a tmux session #3434

antmelon opened this issue Mar 25, 2024 · 7 comments
Labels
bug Something isn't working

Comments

@antmelon
Copy link

Describe the bug
When using a text form such as the commit popup inside of a tmux session, the cursor will flicker at random points on the gui while typing. Outside of a tmux session this behavior is not seen

To Reproduce
Steps to reproduce the behavior:

  1. Launch tmux session
  2. Open Lazygit and enter a text popup such as the commit form
  3. When typing screen tare/cursor flicker can be seen

Expected behavior
No random cursor flashing should be happening on GUI

Version info:
lazygit commit=3675570a391b1a49ddd198b4c7e71e17701d4404, build date=2024-03-23T09:09:11Z, build source=binaryRelease, version=0.41.0, os=linux, arch=amd64, git version=2.25.1
git version 2.25.1

@antmelon antmelon added the bug Something isn't working label Mar 25, 2024
@laurentS
Copy link

I'm observing the same issue, both with lazygit 0.41 and 0.42, both downloaded from the release page (linux_x84_64 builds), running on debian sid. I did not see this problem before, so it's likely a regression in 0.41. As OP, I only see the flickering inside tmux. I use alacritty as a term, but that's probably unrelated.

Current lazygit version: commit=6fcb7eb8bb616c170506312870b3bf15f3dbe37c, build date=2024-05-19T10:15:28Z, build source=binaryRelease, version=0.42.0, os=linux, arch=amd64, git version=2.43.0

@Kaarel
Copy link

Kaarel commented Jun 19, 2024

Same experience on Windows Terminal. Typing into the "Commit summary" is laggy and flickery. See the attached gif. It's not bad recording quality or slow network, this is how it actually looks and feels.

Lazygit version: commit=6fcb7eb8bb616c170506312870b3bf15f3dbe37c, build date=2024-05-19T10:15:28Z, build source=binaryRelease, version=0.42.0, os=windows, arch=amd64, git version=2.45.2.windows.1

Lazygit laggy typing

@peterlandry
Copy link

Same issue with zellij on Mac.

@juanibiapina
Copy link

juanibiapina commented Dec 29, 2024

It seems to me @antmelon and @Kaarel are reporting two different symptoms. I have the flickering reported by @antmelon when running inside tmux, but the typing slowdown reported by @Kaarel happens when running inside tmux -> nvim terminal in NixOS only (since I don't need this setup right now I didn't do further tests). The two issues may not be related.

Cases:

  • alacritty -> lazygit: working ✔️
  • ghostty -> lazygit: working ✔️
  • alacritty -> tmux -> lazygit: flickering ⚠️
  • ghostty -> tmux -> lazygit: flickering ⚠️
  • alacritty -> tmux -> nvim terminal -> lazygit: slow typing ❌

stefanhaller added a commit that referenced this issue Jan 12, 2025
This updates our tcell dependency to v2.8.0, adding support for ghostty
and tmux-256color.

This will hopefully fix #4133, and it might also fix #2962 and #3434
(but I don't understand enough about these to tell).
@stefanhaller
Copy link
Collaborator

Could you test this again with current master? It may (or may not) be improved by the merge of #4166.

@Kaarel
Copy link

Kaarel commented Jan 14, 2025

No change in behaviour for me.

lazygit --version:
commit=91cb1ff29a01fdf643ccc38b97fd816b2a097bec, build date=2025-01-11T04:06:07Z, build source=binaryRelease, version=0.45.0, os=windows, arch=amd64, git version=2.47.1.windows.1

Windows Terminal:
Version: 1.21.3231.0

Note that the typing issue (illustrated by the image above) is present in LazyGit when I run it from Windows Terminal, cmd, Mingw64 based Git Bash (comes with Git for Windows). Typing in each of these respective shell prompts is fine. Typing in other applications (eg neovim, yazi) run from within each of these shells also has no issues. Only seems to affect LazyGit.

If it helps, similar laggyness/flickering is occurring when just navigating in LazyGit panels eg scrolling up and down commit log or keybindings help panel. Makes the entire user experience feel laggy.

@juanibiapina
Copy link

Both bugs still happen on master.

Btw, it ran so smoothly! This project is a great inspiration for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

6 participants