Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump gocui (and tcell) #4166

Merged
merged 1 commit into from
Jan 12, 2025
Merged

Bump gocui (and tcell) #4166

merged 1 commit into from
Jan 12, 2025

Conversation

stefanhaller
Copy link
Collaborator

This updates our tcell dependency to v2.8.0, adding support for ghostty and tmux-256color.

This will hopefully fix #4133, and it might also fix #2962 and #3434 (but I don't understand enough about these to tell).

@stefanhaller stefanhaller added the bug Something isn't working label Jan 11, 2025
Copy link

codacy-production bot commented Jan 11, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a1a8cd11
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a1a8cd1) Report Missing Report Missing Report Missing
Head commit (274e24d) 51749 44716 86.41%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#4166) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This updates our tcell dependency to v2.8.0, adding support for ghostty and
tmux-256color.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong delta diff background color in Ghostty Not loading/parsing unknown terminfo files
3 participants