Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap: add snap manifest #3723

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 35 additions & 0 deletions snap/snapcraft.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: lazygit
title: Lazygit
base: core24
adopt-info: lazygit
summary: simple terminal UI for git commands
description: A simple terminal UI for git commands, written in Go with the gocui library.
version: '0.42.0'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this something I should be bumping whenever I do a release or is this depending on whoever manages the snap entity?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's completely up to you, you can simply set the latest release tag number as the version, or you can follow something completely different.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally, what I do is, I set the version as the release numbers.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not quite following. What are our options? Are we able to:

  1. remove this line completely?
  2. have it dynamically set somehow

I would prefer not to have to update this file each time I release.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we can do that too. How would you like to update it? Following the latest tag or what?

license: MIT
grade: stable
confinement: classic
compression: lzo
contact:
- https://discord.gg/ehwFt2t4wt
- https://twitter.com/DuffieldJesse
donation:
- https://github.com/jesseduffield
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd just add a single URL link: https://github.com/sponsors/jesseduffield

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the same thing, but no problem I'll change it.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be clear I meant to remove the donorbox link

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed the donation link. I'll fix it.

- https://donorbox.org/lazygit
issues: https://github.com/jesseduffield/lazygit/issues
source-code: https://github.com/jesseduffield/lazygit
website: https://jesseduffield.com

parts:
lazygit:
plugin: go
source: https://github.com/jesseduffield/lazygit.git
source-tag: 'v$SNAPCRAFT_PROJECT_VERSION'
source-depth: 1
build-snaps:
- go
build-attributes:
- enable-patchelf
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain what this patchelf thing does.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because this snap will be a classic snap, there will no confinement for this snap working. So, this snap will be mounted in the usr namespace, and thus the rpaths might point to libraries from your system. patchelf is used to patch those elf-interpretors to point towards proper rpaths of the libraries shipped by the snap.


apps:
lazygit:
command: bin/lazygit