-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snap: add snap manifest #3723
base: master
Are you sure you want to change the base?
snap: add snap manifest #3723
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
name: lazygit | ||
title: Lazygit | ||
base: core24 | ||
adopt-info: lazygit | ||
summary: simple terminal UI for git commands | ||
description: A simple terminal UI for git commands, written in Go with the gocui library. | ||
version: '0.42.0' | ||
license: MIT | ||
grade: stable | ||
confinement: classic | ||
compression: lzo | ||
contact: | ||
- https://discord.gg/ehwFt2t4wt | ||
- https://twitter.com/DuffieldJesse | ||
donation: | ||
- https://github.com/jesseduffield | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'd just add a single URL link: https://github.com/sponsors/jesseduffield There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's the same thing, but no problem I'll change it. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To be clear I meant to remove the donorbox link There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Sorry, I missed the donation link. I'll fix it. |
||
- https://donorbox.org/lazygit | ||
issues: https://github.com/jesseduffield/lazygit/issues | ||
source-code: https://github.com/jesseduffield/lazygit | ||
website: https://jesseduffield.com | ||
|
||
parts: | ||
lazygit: | ||
plugin: go | ||
source: https://github.com/jesseduffield/lazygit.git | ||
source-tag: 'v$SNAPCRAFT_PROJECT_VERSION' | ||
source-depth: 1 | ||
build-snaps: | ||
- go | ||
build-attributes: | ||
- enable-patchelf | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you please explain what this patchelf thing does. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Because this snap will be a classic snap, there will no confinement for this snap working. So, this snap will be mounted in the |
||
|
||
apps: | ||
lazygit: | ||
command: bin/lazygit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this something I should be bumping whenever I do a release or is this depending on whoever manages the snap entity?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's completely up to you, you can simply set the latest release tag number as the version, or you can follow something completely different.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally, what I do is, I set the version as the release numbers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not quite following. What are our options? Are we able to:
I would prefer not to have to update this file each time I release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, we can do that too. How would you like to update it? Following the latest tag or what?