Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add removing declarations from a set. #82

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mar-jac
Copy link

@mar-jac mar-jac commented May 31, 2024

This function is designed to remove all declarations associated with a specific set, effectively clearing any links between the set and its declarations without specifying individual declaration identifiers. RemoveDeclarationsFromSet operates at a broader level, targeting all declarations associated with a set.

setName: The name of the set from which all declarations are to be removed.

Use RemoveAllDeclarationsFromSet when you need to completely clear a set of all its associated declarations, which might be useful in scenarios like resetting the set's configuration or prior to deleting the set itself.

@jessepeterson
Copy link
Owner

jessepeterson commented Jun 4, 2024

Thanks! As we talked about, to play devil's advocate: why not just use the enumerate and remove operations already present? :)

If not then this will require some more things:

  1. Implementing the file storage backend, too.
  2. Making it a part of the general all storage.
  3. Create a storage test for it.
  4. Exposing it to the REST-ish API.
  5. Creating script for that exposed API
  6. Docs (OpenAPI & ops guide)

Alternatively you could implement something in the storage interface that retrieves the list of set declarations, and then removes them all. This could be backend-agnostic. But you'd still need steps 3-6. See #102 for an example of a storage change that changes all of the above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants