Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency eslint-plugin-unicorn to v53 #15065

Closed
wants to merge 1 commit into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 10, 2024

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
eslint-plugin-unicorn ^52.0.0 -> ^53.0.0 age adoption passing confidence

Release Notes

sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)

v53.0.0

Compare Source


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Copy link

netlify bot commented May 10, 2024

Deploy Preview for jestjs ready!

Name Link
🔨 Latest commit 4678c4b
🔍 Latest deploy log https://app.netlify.com/sites/jestjs/deploys/6641b766daac58000886070e
😎 Deploy Preview https://deploy-preview-15065--jestjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@fisker
Copy link
Contributor

fisker commented May 10, 2024

@SimenB

I wounder should unicorn ignore toMatchInlineSnapshot in prefer-string-raw rule or let the rule to fix? It seems still works.

The change in Prettier codebase.

https://github.com/prettier/prettier/pull/16275/files#diff-5c4e6839cd59c0bf98a9a280ebbfebe14784a22b0992ea2ed66fa955e20b0211L61

@SimenB
Copy link
Member

SimenB commented May 12, 2024

It should probably be ignored - even if it works when comparing, it'll revert back the next time you update the snapshots. I don't think that's good DX

@fisker
Copy link
Contributor

fisker commented May 12, 2024

Your point make sense, but template-indent also change the template literal, https://github.com/sindresorhus/eslint-plugin-unicorn/blob/d2df181d57a091a8c30a5acf1fe0869d2ccbc2ec/rules/template-indent.js#L116, I guess we can keep the current behavior, change to String.raw when possible, otherwise it's kind of inconsistent to me. User have to run eslint after snapshot updated.

@renovate renovate bot force-pushed the renovate/eslint-plugin-unicorn-53.x branch from c5e8c11 to 4678c4b Compare May 13, 2024 06:47
@SimenB
Copy link
Member

SimenB commented May 13, 2024

Makes sense 👍 I'll disable the rule in here tho, as it IMO makes inline snapshots close to useless (e.g. if you're using watch mode and changing just a single snapshot, all of them will change, then I have to run ESLint after exiting).

Maybe the rule could have some option to ignore if within certain function calls?

@renovate renovate bot deleted the renovate/eslint-plugin-unicorn-53.x branch May 13, 2024 08:23
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants