Skip to content

Commit

Permalink
Remove branch protection rules which have been converted to repositor…
Browse files Browse the repository at this point in the history
…y rulesets.
  • Loading branch information
eclipse-jetty-bot committed Oct 13, 2023
1 parent 7676934 commit af3e815
Showing 1 changed file with 2 additions and 37 deletions.
39 changes: 2 additions & 37 deletions otterdog/jetty.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -132,43 +132,8 @@ orgs.newOrg('jetty') {
],
},
],
branch_protection_rules: [
orgs.newBranchProtectionRule('jetty-9.4.x') {
bypass_pull_request_allowances+: [
"@gregw",
"@janbartel",
"@sbordet",
"@joakime"
],
dismisses_stale_reviews: true,
required_approving_review_count: 1,
required_status_checks+: [
"any:continuous-integration/jenkins/pr-merge",
],
},
orgs.newBranchProtectionRule('jetty-10.0.x') {
bypass_pull_request_allowances+: [
"@gregw",
"@janbartel",
"@sbordet",
"@joakime"
],
dismisses_stale_reviews: true,
required_approving_review_count: 1,
required_status_checks+: [
"any:continuous-integration/jenkins/pr-merge",
],
},
orgs.newBranchProtectionRule('jetty-12.0.x') {
bypass_pull_request_allowances+: [
"@gregw",
"@janbartel",
"@sbordet",
"@joakime"
],
required_approving_review_count: 1,
},
],
# branch protection rules have been converted to a repository ruleset
# in order to support required status checks with a bypass list.
},
orgs.newRepo('jetty.toolchain') {
allow_merge_commit: true,
Expand Down

2 comments on commit af3e815

@olamy
Copy link
Member

@olamy olamy commented on af3e815 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@netomi which file contains repository ruleset??

@netomi
Copy link
Contributor

@netomi netomi commented on af3e815 Oct 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are not yet supported by the tool, so they have been created manually, but will support them asap to have it also contained in this file: https://gitlab.eclipse.org/eclipsefdn/security/otterdog/-/issues/53

Please sign in to comment.