Revert "Create org webhook for jenkins (#20)"

[joakime]

This reverts commit 654f8f5.

It is not appropriate to have Jenkins Webhooks at org level.
This should be reverted.

[netomi]

I may have suggested something that is not inline with your CI configuration at webtide, however it is common practice for many eclipse projects to enable a webhook on organization level to trigger builds on jenkins. My understanding is that the jenkins instance only receives information about PRs or pushes from repos and starts a build if a corresponding job is available that has GitHub hook trigger for GITScm polling enabled. If events are received for repos where no job is configured, nothing will happen.

Now, if you prefer to have an explicit webhook defined on repo level for repos which have such a job on jenkins, its perfectly fine for me ofc but I would like to know your reasoning about this change so that I better know for the future.

[github-actions]

Diff for 3edddf5:

Printing local diff for configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Actions are indicated with the following symbols:
+   create
!   modify
!   forced update
-   delete

Organization jetty[id=jetty]

-   remove org_webhook[url="https://jenkins.webtide.net/github-webhook/"] {
-     active                                                   = true
-     content_type                                             = "json"
-     events                                                   = [
-       "pull_request"
-       "push"
-     ],
-     insecure_ssl                                             = "0"
-     url                                                      = "https://jenkins.webtide.net/github-webhook/"
-   }

+   add repo_webhook[url="https://jenkins.webtide.net/github-webhook/", repository="jetty-website"] {
+     active                                                   = true
+     content_type                                             = "json"
+     events                                                   = [
+       "pull_request"
+       "push"
+     ],
+     insecure_ssl                                             = "0"
+     url                                                      = "https://jenkins.webtide.net/github-webhook/"
+   }

+   add repo_webhook[url="https://jenkins.webtide.net/github-webhook/", repository="jetty.alpn.api"] {
+     active                                                   = true
+     content_type                                             = "json"
+     events                                                   = [
+       "pull_request"
+       "push"
+     ],
+     insecure_ssl                                             = "0"
+     url                                                      = "https://jenkins.webtide.net/github-webhook/"
+   }

+   add repo_webhook[url="https://jenkins.webtide.net/github-webhook/", repository="jetty.docker"] {
+     active                                                   = true
+     content_type                                             = "form"
+     events                                                   = [
+       "pull_request"
+       "push"
+     ],
+     insecure_ssl                                             = "0"
+     url                                                      = "https://jenkins.webtide.net/github-webhook/"
+   }

+   add repo_webhook[url="https://jenkins.webtide.net/github-webhook/", repository="jetty.project"] {
+     active                                                   = true
+     content_type                                             = "json"
+     events                                                   = [
+       "pull_request"
+       "push"
+     ],
+     insecure_ssl                                             = "0"
+     url                                                      = "https://jenkins.webtide.net/github-webhook/"
+   }

+   add repo_webhook[url="https://jenkins.webtide.net/github-webhook/", repository="jetty.toolchain"] {
+     active                                                   = true
+     content_type                                             = "json"
+     events                                                   = [
+       "pull_request"
+       "push"
+     ],
+     insecure_ssl                                             = "0"
+     url                                                      = "https://jenkins.webtide.net/github-webhook/"
+   }
  
  Plan: 5 to add, 0 to change, 1 to delete.

Showing diff to a canonical version of the configuration at '/home/runner/work/.eclipsefdn/.eclipsefdn/otterdog-configs/otterdog.json'

Organization jetty[id=jetty]

[olamy]

@joakime Why?

[joakime]

We don't want to jeopardize jenkins.webtide.net use for the important repos by having repos that never use it (and having github flag it as a problematic webhook server).

A few or our repos will use jenkins.webtide.net, not 100% of them.

[netomi]

changes are live

[fredg02]

We don't want to jeopardize jenkins.webtide.net use for the important repos by having repos that never use it (and having github flag it as a problematic webhook server).

Out of curiosity: why/how would GitHub flag jenkins.webtide.net as a "problemativ webhook server"? With a webhook on the org level, jenkins.webtide.net would receive all webhook events just fine, but only start a build for repositories that have a build job set up. jenkins.webtide.net won't return a 404 or similar error code to GitHub for repos that have no build job, so GitHub has no way of telling that a webhook is sent that does not kick off a build (and they mostly likely don't care).