Issue #11873 - Server resources are not found if the server is subclassed in a different package #11874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n Server Signed-off-by: Lachlan Roberts <[email protected]>
sbordet
approved these changes
Jun 4, 2024
joakime
reviewed
Jun 4, 2024
| return Stream.of( | ||
| new Server(), | ||
| new Server(){} | ||
| ).map(Arguments::of); |
There was a problem hiding this comment.
I don't think this tests what you think it tests.
There was a problem hiding this comment.
@joakime this test fails before fix and now passes.
The idea is that it is trying to load jetty-dir.css, and it does getClass().getResource(name), internally this appends the package name as the resource does not start with /, and because the server is subclassed with the {} it is looking for /org/eclipse/jetty/server/subpackage/jetty-dir.css which does not exist.
There was a problem hiding this comment.
So the second argument is an anonymous subclass. got it.
joakime
approved these changes
Jun 4, 2024
lachlan-roberts
added
the
Sponsored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11873