Jetty 12.1.x Infinispan flaky tests #12338
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olamy
commented
Oct 1, 2024
olamy
commented
- use Infinispan image 15.0.9, use UUID for cache name
- checkstyle
- use a single instance via singleton holder
- reduce memory usage of Infinispan
janbartel
requested changes
Oct 2, 2024
| } | ||
|
|
||
| } | ||
|
|
||
| public RemoteInfinispanTestSupport(String cacheName) | ||
| { | ||
| Objects.requireNonNull(cacheName, "cacheName cannot be null"); |
There was a problem hiding this comment.
Is the cacheName now no longer used?
...n-common/src/main/java/org/eclipse/jetty/session/test/tools/RemoteInfinispanTestSupport.java
Outdated
Show resolved
Hide resolved
...n-common/src/main/java/org/eclipse/jetty/session/test/tools/RemoteInfinispanTestSupport.java
Outdated
Show resolved
Hide resolved
| private static final GenericContainer<?> infinispan = new GenericContainer<>(IMAGE_NAME); | ||
|
|
||
| static | ||
| private static final class Holder |
There was a problem hiding this comment.
What's the benefit of doing it this way vs having statics?
|
@janbartel still a draft and working on it |
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
olamy
force-pushed
the
jetty-12.1.x-infinispan-flaky
branch
from
85ba257
to
489dca0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.