fix: "open_sublime_text_dir" command exception on Direct-IO disk

I set my TEMP dir to a Direct-IO disk created by a Ramdisk software. And "path.resolve()" failed on that disk. OSError: [WinError 1] 功能錯誤。: 'R:\\TEMP-J~1\\..' Signed-off-by: Jack Cherng <[email protected]>
jfcherng-sublime · Apr 7, 2024 · abbd529 · abbd529
1 parent e76f096
commit abbd529
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/plugin/commands/open_git_repo_on_web.py b/plugin/commands/open_git_repo_on_web.py
@@ -5,10 +5,9 @@
 import shutil
 import subprocess
 import threading
-from collections.abc import Callable
 from functools import wraps
 from pathlib import Path
-from typing import Any, TypeVar, cast
+from typing import Any, Callable, TypeVar, cast
 
 import sublime
 import sublime_plugin

diff --git a/plugin/commands/open_sublime_text_dir.py b/plugin/commands/open_sublime_text_dir.py
@@ -7,16 +7,24 @@
 import sublime
 import sublime_plugin
 
+assert __package__
+
 PACKAGE_NAME = __package__.partition(".")[0]
 
 
 @lru_cache
 def _get_folder_map() -> dict[str, str]:
+    def resolve_path(path: Path) -> Path:
+        try:
+            return path.resolve()  # will fail on a Direct-IO disk
+        except OSError:
+            return path
+
     cache_path = Path(sublime.cache_path())
     packages_path = Path(sublime.packages_path())
 
     return {
-        name: str(path.resolve())
+        name: str(resolve_path(path))
         for name, path in (
             # from OS
             ("home", Path.home()),