Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed included from _get_collection_helper() #560

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlmightyOatmeal
Copy link

@AlmightyOatmeal AlmightyOatmeal commented Jul 10, 2016

* Fixes jfinkels#559 by removing the included portion instead of trying to map the entire table.
@jfinkels
Copy link
Owner

This is not going to be the right solution to this problem. We still need to fetch and return the resources that are requested to be included.

@AlmightyOatmeal
Copy link
Author

The functionality should be removed until it can perform as described in the features. This would be considered regression and should not be made available until it is functioning properly. In my opinion, it is the correct fix for the time being.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants