Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask 1.0.2 compatibility #692

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Flask 1.0.2 compatibility #692

wants to merge 2 commits into from

Conversation

damahou
Copy link

@damahou damahou commented Nov 11, 2018

Flask 1.0.2 doesn't allow dots in Blueprint view functions since commit pallets/flask@2f57a0b

As there are some view function names ended with .relationship, Flask-Restless breaks recent versions of Flask . I have changed this names and now they ends with _relationship. It seems to work with Flask 1.0.2.
This solves #686.

@ajite
Copy link

ajite commented Jan 15, 2019

This works for me with Flask 1.0.2 and Python 3.6.5. Can this be merged?

@dakoner
Copy link

dakoner commented Mar 5, 2019

Don';t really want to +1, but +1. The examples in the documentation don't even work without this patch.

@pawulon
Copy link

pawulon commented Mar 15, 2019

I think that similar fix should be applied to eval
eval_api_name = '{0}_eval'.format(apiname)

@michalkurdziel
Copy link

this will be merged?

@sholsapp
Copy link

@jfinkels are you still maintaining this library?

@jfinkels
Copy link
Owner

jfinkels commented Apr 6, 2020 via email

@sholsapp
Copy link

sholsapp commented Apr 6, 2020

That's sad to hear. It was a great library. Thanks for building it and maintaining it over the years. :)

Can you mark the library as deprecated somehow? Stuff like that talked about in https://medium.com/maintainer-io/how-to-deprecate-a-repository-on-github-8f0ceb9155e sounds like a decent approach, and similar to what others have been doing.

@jfinkels
Copy link
Owner

jfinkels commented Apr 26, 2020 via email

@mrevutskyi
Copy link

Hi, there is a fork project Flask-Restless-NG that has this issue and some other issues fixed, along with performance improvements

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants