Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support limit and offset in AqlQueryBuilder #371

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Support limit and offset in AqlQueryBuilder #371

merged 4 commits into from
Nov 7, 2023

Conversation

sailingcat
Copy link
Contributor

@sailingcat sailingcat commented Mar 29, 2023 •
edited
Loading

  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • This pull request is on the dev branch.

@sailingcat
Copy link
Contributor Author

Includes limit (Done in #294).

@sailingcat sailingcat marked this pull request as draft July 3, 2023 07:20
@sailingcat sailingcat marked this pull request as ready for review July 3, 2023 07:20
@sailingcat
Copy link
Contributor Author

@eyalbe4 Could you please review my PR please ?

@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Oct 1, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Oct 1, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@yahavi yahavi changed the title feat(aql): Adding Pagination to AQL Query Builder Support sort and limit in AqlQueryBuilder Nov 7, 2023
@yahavi yahavi added the improvement Automatically generated release notes label Nov 7, 2023
@yahavi yahavi changed the title Support sort and limit in AqlQueryBuilder Support limit and offset in AqlQueryBuilder Nov 7, 2023
@yahavi yahavi added the safe to test Approve running integration tests on a pull request label Nov 7, 2023
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Nov 7, 2023
yahavi
yahavi approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@yahavi yahavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sailingcat!

@yahavi yahavi merged commit de29d0b into jfrog:dev Nov 7, 2023
8 of 11 checks passed
@sailingcat sailingcat deleted the pagination branch November 8, 2023 13:35
@yahavi
Copy link
Member

yahavi commented Nov 9, 2023

Hey @sailingcat,
The latest release of Artifactory Java client, version 2.17.0, is now available. This update incorporates the changes mentioned in #371 & #370, which you contributed. Please consider upgrading, and your feedback would be greatly valued.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yahavi yahavi yahavi approved these changes

Assignees
No one assigned
Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sailingcat @yahavi